Text 251, 166 rader
Skriven 2005-02-23 21:58:00 av "randy Birch" <rgb_remove (1:278/230)
Ärende: Re: Error: Procedure too large...need help breaking up synta
====================================================================


You are re-asking the same question you asked last December. The example I
posted showed how to reduce the repetitious code.

-----------
I'd be examining the repetitive code to see if it could be standardized as
much as possible, then move the standardized code to a subroutine that you
would call as needed passing the required parameters. In air code something
along the lines of:

private sub setparams(celltext as string, cellunit as long, cellfontbold as
boolean, optional cellformula as string)

   with surveyApp.Selection
        .MoveRight cellunit
        .Font.Bold = cellfontbold
        .TypeText celltext

       if len(cellformula) then
         .InsertFormula cellformula,
       endif

    end with

end sub

.... then call

    setparams("No", wdCell, False)
    buff = rs("paaexplno")
    setparams(buff, wdCell, False)
    setparams("", wdCell, False, b2/b6*100")
    NumberFormat:="0%"

etc...

-----------

--


Randy Birch
MS MVP Visual Basic
http://vbnet.mvps.org/


<pkruti@hotmail.com> wrote in message
news:1103057669.748176.69540@z14g2000cwz.googlegroups.com...
: am writing a program that creates a huge report in Word and now i am
: getting an complie error: Procedure too large =( i am pretty sure its
: because of bad program writing but alot of my stuff is repeated but i
: am not sure how else to write the code. i believe that i could call a
: procedure but not sure how to go about doing it. Below is a sample of
: the code i am writing and is just 1 question out of 18 and i am
: basically repeating alot of the syntax. so does anyone have any idea on
: how i could condensed it or how to do a "call" procedure? if so maybe
: an example would help. thanks
:
: 'Question #3
: rs.Open "SELECT * FROM yesno_holding", conn, adOpenDynamic,
: adLockOptimistic
:
: surveyApp.Selection.EndKey unit:=wdStory
: surveyApp.Selection.TypeParagraph
: surveyApp.Selection.Font.Bold = True
: surveyApp.Selection.Font.Name = "arial"
: surveyApp.Selection.Font.Size = 10
: surveyApp.Selection.TypeText Text:="3. Were the procedures for the
: Purchaser Acceptance Agreement clearly explained to you by your
: Assistant Project Manager?"
: surveyApp.Selection.TypeParagraph
: surveyApp.Selection.TypeParagraph
:
: Set table1 =
: surveyApp.Selection.Tables.Add(surveyApp.Selection.Range, 6, 3)
: table1.AllowAutoFit = True
:
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:="Yes"
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:=rs("paaexplyes")
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.InsertFormula Formula:="=b1/b6*100",
: NumberFormat:="0%"
:
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:="No"
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:=rs("paaexplno")
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.InsertFormula Formula:="=b2/b6*100",
: NumberFormat:="0%"
:
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:="Maybe"
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:=rs("paaexplmb")
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.InsertFormula Formula:="=b3/b6*100",
: NumberFormat:="0%"
:
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:="No Response"
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:=rs("paaexplother")
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.InsertFormula Formula:="=b4/b6*100",
: NumberFormat:="0%"
:
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:="Total"
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.InsertFormula Formula:="=SUM(ABOVE)",
: NumberFormat:=""
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.InsertFormula Formula:="=SUM(above)*100",
: NumberFormat:="0%"
: rs.Close
:
: surveyApp.Selection.EndKey unit:=wdStory
: surveyApp.Selection.TypeParagraph
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeText Text:="If no, may I ask why not?"
: rs.Open "PAAWHY", conn, adOpenDynamic, adLockOptimistic
: surveyApp.Selection.TypeParagraph
: surveyApp.Selection.Font.Bold = False
: surveyApp.Selection.TypeParagraph
:
: Set table1 =
: surveyApp.Selection.Tables.Add(surveyApp.Selection.Range, 6, 2)
: table1.AllowAutoFit = True
:
: Do While Not rs.EOF
: surveyApp.Selection.TypeBackspace
: surveyApp.Selection.TypeText Text:=rs("paawhy")
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.TypeText Text:=rs("expr1")
: surveyApp.Selection.MoveRight unit:=wdCell
: surveyApp.Selection.TypeParagraph
: rs.MoveNext
: Loop
: rs.Close
:



--- UseNet To RIME Gateway @ 2/23/05 9:51:27 PM ---
 * Origin: MoonDog BBS, Brooklyn,NY, 718 692-2498, 1:278/230 (1:278/230)